Fix z3 install and CN tests for Dockerfiles #712
Conversation
podhrmic
changed the title
|
@dc-mak this fixes the error in https://github.com/rems-project/cerberus/actions/runs/11784243588/job/32823035384 |
|
Hmm, to minimise this in the future, can you please also adjust the docker.yml to run on any PR that edits the docker.yml or any Dockerfiles? https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#pull_request |
…e. This should be OK as we don't expect the dockerfiles to be changing very often and from multiple branches
|
@dc-mak I tried - but as you can see, the on-change triggers do not seem to work very well (or at all). This matches my previous experience, so if you have an idea how to fix this go ahead, otherwise I would just merge as is, as moving forward we shouldn't need to change the Dockerfiles much |
|
It seems to have triggered the workflow but I did it when the actual scheduled job is also running, so it is waiting behind that to finish... https://github.com/rems-project/cerberus/actions/runs/11803628827 |
It's not allowed anyway (as desired) but it fails the CI spuriously.
|
@dc-mak I would also recommend that the Adding: Indeed, this will only work on |
Fair point, feel free to add and push |
|
https://docs.docker.com/build/ci/github-actions/share-image-jobs https://docs.docker.com/reference/cli/docker/buildx/build/#output There also seem to be some caching options of some sort. |
|
@dc-mak I updated the job dependency. I cannot use the caching, because I am building the images with attestation, and that is allowed only if you directly push the images into the registry ( |
|
@dc-mak any reason not to merge this? |
|
I’ve been writing 2000 words/day. |
* Add GPG key import to the Redhat build to avoid package signature errors * Fix the docker test script, and update z3 installation * Run docker actions any time a dockerfile is changed * Specify the working directory for the container * Minimal dockerfile change (added documentation) to test triggering the docker action * Trigger docker action on any push event that also changes a Dockerfile. This should be OK as we don't expect the dockerfiles to be changing very often and from multiple branches * Also enable docker action run any time there is a change in the docker.yml file * Change the path hoping to trigger the docker action * Try disabling the scheduled run * Re-enabling the scheduled run * Try triggering docker.yml on PR * Disable Docker push on PRs It's not allowed anyway (as desired) but it fails the CI spuriously. * Fix Docker push condition * Fix other Docker push condition * Update test-docker image dependencies --------- Co-authored-by: Dhruv Makwana <[email protected]>
The nighly docker build hid an error in docker invocation. I fixed the invocation of
run-cn.shand properly installed z3 via opam in both docker images.