Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single fetch: allow setting a nonce on StreamTransfer's script tags #9359

Closed
haines opened this issue May 2, 2024 · 2 comments · Fixed by #9364
Closed

Single fetch: allow setting a nonce on StreamTransfer's script tags #9359

haines opened this issue May 2, 2024 · 2 comments · Fixed by #9364
Labels
bug:unverified feat:single-fetch package:server-runtime

Comments

@haines
Copy link
Contributor

haines commented May 2, 2024 •
edited
Loading

Expected Behavior

We have a CSP in place which requires a nonce on inline scripts, so we need to add that to the script tags created in the StreamTransfer component.

Actual Behavior

There is no way afaict to set the nonce for these scripts.
@haines haines mentioned this issue May 3, 2024
Merged
2 tasks
@brophdawg11 brophdawg11 linked a pull request May 6, 2024 that will close this issue
Allow a nonce to be set on single fetch stream transfer inline scripts #9364
Merged
2 tasks
@brophdawg11 brophdawg11 added the awaiting release This issue has been fixed and will be released soon label May 6, 2024
@brophdawg11
Copy link
Contributor

This fix is available in 2.9.2-pre.1 if you'd like to give it a shot and see if it resolves your issue! Here's the draft release notes: https://github.com/remix-run/remix/blob/release-next/CHANGELOG.md#v292

@brophdawg11 brophdawg11 removed the awaiting release This issue has been fixed and will be released soon label May 10, 2024
@brophdawg11
Copy link
Contributor

2.9.2 is released - https://github.com/remix-run/remix/releases/tag/remix%402.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unverified feat:single-fetch package:server-runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow a nonce to be set on single fetch stream transfer inline scripts haines/remix
2 participants
@haines @brophdawg11