V2 issue: AppConfig should not have v2 future flags

[kentcdodds]

What version of Remix are you using?

0.0.0-nightly-49e8da1-20230823

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

TS Playground:

import { type AppConfig } from "@remix-run/dev"; // types: 0.0.0-nightly-49e8da1-20230823

export default {
	cacheDirectory: './node_modules/.cache/remix',
	ignoredRouteFiles: ['**/*'],
	serverModuleFormat: 'esm',
	serverPlatform: 'node',
	tailwind: true,
	postcss: true,
	watchPaths: ['./tailwind.config.ts'],
	future: {
    // these should not be allowed:
		v2_headers: true,
		v2_meta: true,
		v2_errorBoundary: true,
		v2_normalizeFormMethod: true,
		v2_routeConvention: true,
		v2_dev: true,
	},
} satisfies AppConfig

Expected Behavior

v2 future flags should not be allowed with nightly (v2)

Actual Behavior

v2 future flags are allowed in nightly (v2)

[brophdawg11]

Huh, interesting. That type is Partial<FutureConfig> and FutureConfig is empty, but I guess TS allows other props since they satisfy the base value (https://www.typescriptlang.org/docs/handbook/2/objects.html#excess-property-checks).

I guess we can union that with a never: https://www.typescriptlang.org/play?#code/JYOwLgpgTgZghgYwgAgGIFczqhAwgexBmAHNkBvAKAEgA3AZgH0o4ATVCOLHALmQCN8+ADacQlAL6VKoSLEQoAggAdlBIqQqVkO5DEzYIAfj4AFOFDDA4wgDwZueQsRIA+ZADIt1agG1lUPjKAHJwALYQfADOYFCgJAC6fCAQtNAA3DQSmVKUEAAeyviWyKwQ8OjCYN76jnxUPgzMbBxchnyx6BAANDR0AEyMAO5gABYQCADWHVBdvdQSvRLIUVzAUcQQUcgqas6klEA

[kentcdodds]

That sounds good. I'm just sure many people will upgrade and they'll have to run the server to realize they still need to remove the old feature flags, so this is probably worth it.

[brophdawg11]

Yeah - since the config is not TS by default we did add some build time warnings for those in https://github.com/remix-run/remix/blob/dev/packages/remix-dev/config.ts#L566. But if folks are using TS like this it would be nice to let them know 👍

[kentcdodds]

Agreed, those warnings are definitely nice 👍 Thanks!

[brophdawg11]

Fixed by #7261 and will be included in Remix v2

[github-actions]

🤖 Hello there,

We just published version 2.0.0-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!