Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run dev does not quit after receiving Ctrl-C #6569

Closed
1 task done
zbynekwinkler opened this issue Jun 8, 2023 · 5 comments
Closed
1 task done

npm run dev does not quit after receiving Ctrl-C #6569

zbynekwinkler opened this issue Jun 8, 2023 · 5 comments

Comments

@zbynekwinkler
Copy link

What version of Remix are you using?

1.17.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

npm create-remix@latest
pick Typescript, Cloudflare Pages, no stack, install
npm run dev
press Ctrl-C

Expected Behavior

After printing Shutting down local server all subprocess with terminate and control will be returned to the terminal.

Actual Behavior

It hangs forever. If the process are killed from the outside, the terminal is left in inconsistent state and needs to be reset.

@zbynekwinkler
Copy link
Author

Application created from the cloudflare-workers template behaves as expected (quits on Ctrl-C and the terminal does not need to be reset).

@pmbanugo
Copy link
Contributor

It also happens with Remix 1.16.1. I can't confirm yet if it happens only if you use wrangler 3.

@brophdawg11 brophdawg11 added this to v2 Aug 3, 2023
@brophdawg11 brophdawg11 moved this to Backlog in v2 Aug 3, 2023
@pcattori pcattori moved this from Backlog to In progress in v2 Aug 9, 2023
@pcattori
Copy link
Contributor

pcattori commented Aug 9, 2023

Fixed by #6663 / cannot reproduce on nightly:

npx create-remix@nightly --template https://github.com/remix-run/remix/tree/main/templates/cloudflare-pages
cd my-remix-app
npm run dev
^C
ps aux | rg 'remix' # shows no results
ps aux | rg 'node' # shows no results

Tried hitting CTRLC at different timings (before wrangler spins up, after it prints initial messages, after Remix app is running stably, etc...), but nothing I tried resulted in dangling processes.

@pcattori pcattori closed this as completed Aug 9, 2023
@pcattori pcattori moved this from In progress to Closed in v2 Aug 9, 2023
@pmbanugo
Copy link
Contributor

pmbanugo commented Aug 9, 2023

@pcattori Will this be part of the next release? or only until v2 is shipped?

@pcattori
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Closed
Development

No branches or pull requests

4 participants