Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2_meta root route error message is blank for root route #5037

Closed
ryanflorence opened this issue Jan 9, 2023 · 3 comments
Closed

v2_meta root route error message is blank for root route #5037

ryanflorence opened this issue Jan 9, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ryanflorence
Copy link
Member

What version of Remix are you using?

1.9.0

Steps to Reproduce

  • bootstrap a "just the basics" remix app
  • add the future.v2_meta flag
  • boot the app and visit a page

Expected Behavior

Error message has "root" as the route name

Actual Behavior

It's just blank.

Error: The v2_meta API is enabled in the Remix config, but the route at returns an invalid value.

It should say "root". I wonder if our root route has a proper ID though. We're going to want it to be "root" for the existing APIs like parentsData in meta and for react router useRouteData that we have in 1.10. I bring this up because I'm anticipating a quick solution is route.id || "root" but maybe there's a deeper problem (the route doesn't have an ID?)

@ryanflorence ryanflorence changed the title v2_meta root route error message is blank v2_meta root route error message is blank for root route Jan 9, 2023
@ryanflorence ryanflorence added bug Something isn't working and removed bug:unverified labels Jan 9, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.10.1-pre.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-d371904-20230112 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.10.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants