Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'future' is missing in type 'typeof import("./node_modules/@remix-run/dev/server-build")' #4766

Closed
simonsinclair opened this issue Dec 4, 2022 · 7 comments · Fixed by #4771
Assignees
Labels
bug Something isn't working

Comments

@simonsinclair
Copy link

simonsinclair commented Dec 4, 2022

What version of Remix are you using?

1.8.0

Steps to Reproduce

remix.config.js

/** @type {import('@remix-run/dev').AppConfig} */
module.exports = {
  devServerBroadcastDelay: 1000,
  ignoredRouteFiles: ['**/.*'],
  server: './server/index.ts',
};

server/index.ts

import express from 'express';
import { createRequestHandler } from '@remix-run/express';
import * as build from '@remix-run/dev/server-build';

const app = express();

app.use('/build', express.static('public/build', { immutable: true, maxAge: '1y' }));

app.use(express.static('public', { maxAge: '1h' }));

app.all(
  '*',
  createRequestHandler({
    build,
    mode: process.env.NODE_ENV,
  })
);

app.listen(3000);

Expected Behavior

The changes to @remix-run/server-runtime from 1.7.6 (the version I was using) to 1.8.0 are listed as patch and minor changes, so I expected my existing code to be compatible.

Actual Behavior

error

Note

I tried adding future: {} to remix.config.js as per the discussion in #4759, but this does not resolve the issue.

@machour
Copy link
Collaborator

machour commented Dec 4, 2022

@simonsinclair Are all your remix deps up to date? A gist with both your package.json & package-lock.json would help 🙏🏼
Can you also provide the @remix-run/dev/server-build.js file?

@machour machour added the needs-response We need a response from the original author about this issue/PR label Dec 4, 2022
@simonsinclair
Copy link
Author

Are all your remix deps up to date? A gist with both your package.json & package-lock.json would help 🙏🏼 Can you also provide the @remix-run/dev/server-build.js file?

Yes, they should be. Here are the Gists:

@machour machour removed the needs-response We need a response from the original author about this issue/PR label Dec 4, 2022
@MichaelDeBoey
Copy link
Member

It seems like the grunge-stack has this problem as well
https://github.com/remix-run/grunge-stack/actions/runs/3618711788/jobs/6098889351#step:6:13

@MichaelDeBoey
Copy link
Member

@simonsinclair This seems to be a duplicate of #4759?

@MichaelDeBoey MichaelDeBoey added bug Something isn't working and removed bug:unverified labels Dec 5, 2022
@machour
Copy link
Collaborator

machour commented Dec 5, 2022

@MichaelDeBoey #4759 is about Vercel. Kept both open to gather the maximum feedback for the team.

@chaance
Copy link
Collaborator

chaance commented Dec 5, 2022

To be clear, this is only a TypeScript issue, correct? Are there any runtime problems as a result of this issue?

@chaance
Copy link
Collaborator

chaance commented Dec 5, 2022

Confirmed that this is fixed in 1.8.1-pre.0. Patch coming soon 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants