Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public/build directory is getting bloated #3166

Closed
thomasverleye opened this issue May 11, 2022 · 2 comments
Closed

public/build directory is getting bloated #3166

thomasverleye opened this issue May 11, 2022 · 2 comments
Labels
bug:unverified duplicate This issue or pull request already exists

Comments

@thomasverleye
Copy link
Contributor

What version of Remix are you using?

1.4.3

Steps to Reproduce

  • Run remix dev and change some files.
  • Multiple files get generated inside public/build.

Expected Behavior

public/build folder should be cleared on each build.

Actual Behavior

Multiple files get generated inside public/build which make the folder bloated.
See #3156 and #2425 for reports on this.

@thomasverleye
Copy link
Contributor Author

Been testing the watch function from the CLI Commands.
It seems like the exitHook can't be triggered properly.
See: https://github.com/remix-run/remix/blob/main/packages/remix-dev/cli/commands.ts#L222

When testing the exitHook inside the dev function, it does get triggered, so I'm afraid the watch function can't be run async and maybe should return a callback function instead closes everything correctly inside the dev function.

Not sure if that's a solid solution though.

@machour
Copy link
Collaborator

machour commented May 11, 2022

Thank you for reporting this @thomasverleye, but there's already an issue filled-in! See #2432

@machour machour added the duplicate This issue or pull request already exists label May 11, 2022
@machour machour closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug:unverified duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants