Remove default Router export #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm similarly meh on this. It will break (trivially) some existing uses, but would be good to make it clear that you need more than just the default import. |
|
You can't do anything useful if you're just using the default export anyway, since you'd (almost) always need |
|
Yeah, that's why I'm only meh on this. The breakage isn't that big of a deal. |
|
Just realized the best argument for this is when people do this:
They render a bunch of routers all over the place and have no clue what is happening! |
|
Also, can we get an entry in the CHANGES.md about this? Somebody somewhere is using it. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.