Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of "revertPop" method in Browser Histrory #6670

Closed
PetrivskyiTaras opened this issue Mar 28, 2019 · 2 comments
Closed

Incorrect behavior of "revertPop" method in Browser Histrory #6670

PetrivskyiTaras opened this issue Mar 28, 2019 · 2 comments

Comments

@PetrivskyiTaras
Copy link

PetrivskyiTaras commented Mar 28, 2019

Hi, try to describe the problem.

I user Link component for navigation.
Step for reproducing:

  1. Block transition to back - history.block(message) in my case message is boolean true or false
  2. Call history.goBack() transition is blocked!
  3. Inside will be called method "revertPop" with fromLocation param (it is a location that was created with "getDOMLocation" method and use event.state data). In my keys state is empty. It is browser event data.
    As a result, will be called "go(delta)" with incorrect delta (See attached file)
    revertPop
@timdorr
Copy link
Member

timdorr commented Mar 28, 2019

See remix-run/history#690

@timdorr timdorr closed this as completed Mar 28, 2019
@PetrivskyiTaras
Copy link
Author

Thanks a lot, I didn't find that issue.
I've got your point. Will find another solution.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants