Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass React Strict Tests #6481

Closed
dstroot opened this issue Nov 16, 2018 · 2 comments
Closed

Pass React Strict Tests #6481

dstroot opened this issue Nov 16, 2018 · 2 comments

Comments

@dstroot
Copy link

dstroot commented Nov 16, 2018

Version

"react-router-dom": "^4.3.1"

Test Case

Enable React Strict Mode - View console

Warning: Unsafe lifecycle methods were found within a strict-mode tree:

componentWillMount: Please update the following components to use componentDidMount instead: BrowserRouter, Route, Router, SideEffect(NullComponent), Switch, t

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Route, Router, Switch

componentWillUpdate: Please update the following components to use componentDidUpdate instead: t

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings

Steps to reproduce

Enable React Strict Mode - View console

Expected Behavior

Passes React Strict Mode

Actual Behavior

Does not pass React Strict Mode

@timdorr
Copy link
Member

timdorr commented Nov 16, 2018

This is already done on master. You can use the 4.4 betas or wait for a final release.

@timdorr timdorr closed this as completed Nov 16, 2018
@timdorr
Copy link
Member

timdorr commented Nov 16, 2018

See #6060 and #6385

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants