-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A11Y in React Router core #3154
Comments
More I think about this the more I think this should be userland since there doesnt seem to be a good standard for implementing this, maybe we could include a11y docs but not include it in core? |
Yeah – judging by the things you have there, I think this has to be in userland; there doesn't seem to be a good generic solution that we can just pull into core. |
How about resetting the focus on the route changes? I have the feeling that every time that the route changes, the focus should be reset (emulating a page refresh). Do you guys have any recommendation on this? |
+1 I'm looking into a11y issues with the focus not being reset on route changes. |
Any update on resetting the focus on the route changes? @iamrandys @alansouzati |
Discussion seems to have moved to #5210. |
At the moment React Router does a great job of emulating browser behaviour to give the user a great experience e.g. keeping scroll position, history etc.
However one pitfall is accessibility, right now when changing views a screenreader user will not get the same indications they would when performing a full page reload.
Do you think accessibility should be considered something that is in core?
However to do this seamlessly is not so simple:
title
page has loaded'You could argue that this should be done in userland, however if it were not an a11y issue I imagine this would be considered very broken - if scrolling were not persisted for example.
It'd be great if this were in core because it'd mean react-router projects would be more accessible out of the box and show the react communities commitment to accessibility.
(I'm not an expert in accessibility so feel free to correct anything I've misunderstood 😄)
The text was updated successfully, but these errors were encountered: