Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 breaks back button in preact-router #856

Closed
merlinstardust opened this issue Feb 16, 2021 · 2 comments
Closed

5.0.0 breaks back button in preact-router #856

merlinstardust opened this issue Feb 16, 2021 · 2 comments

Comments

@merlinstardust
Copy link

When attempting to upgrade to [email protected] in my preact app, the back button no longer works as it did previously. [email protected] works fine.

I found this issue in preact-router but I think this may be a fix that history needs to do.

It may or may not be related to this comment on the v5 undocumented breaking changes thread.

@StringEpsilon
Copy link

This comment makes me pretty sure that the breakage came from the change in signature for the history.listen() callback.

I documented that in my gist here and midahp effectively came up with the same workaround.

@mjackson
Copy link
Member

It sounds like this is an issue that preact-router needs to fix to be compatible with v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants