Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

confirmTransitionTo prompt require type string, maybe it shouldn't? #489

Closed
fernandojbf opened this issue Jun 9, 2017 · 2 comments
Closed

confirmTransitionTo prompt require type string, maybe it shouldn't? #489

fernandojbf opened this issue Jun 9, 2017 · 2 comments

Comments

@fernandojbf
Copy link

Hi all,

This may not make sense but maybe we could pass prompt as an Object? With this we can configure different outcomes of the getUserConfirmation function. Any thoughts about this or does it not make any sense?

Cheers
@fernandojbf fernandojbf mentioned this issue Jun 9, 2017
Closed
@lourd lourd mentioned this issue Jun 14, 2017
Closed
@TimoStaudinger
Copy link

We are facing the same issue right now.

We'd like to have a multi-option confirmation popup (save/discard/cancel) and need a way to pass additional details about the actions, and an action handler into getUserConfirmation. This is currently not possible.

Any thoughts on this? More than happy to submit a PR if there is interest.

@mymattcarroll mymattcarroll mentioned this issue Jul 26, 2018
Closed
@mjackson
Copy link
Member

We are removing history.block (it's buggy, see #690), so this won't be an issue for us anymore.

@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow getUserConfirmation callback result to cater for any type of value
3 participants
@mjackson @TimoStaudinger @fernandojbf