Initial jsonapi support (without compound documents) #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot_in_json, primary_key, or root_element with Her::JsonApiModel
|
👍 |
|
+1 |
hubert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step in providing first-class support for JSON API within Her. It targets the 1.0 spec. Currently, it supports the basic CRUD operations and metadata, but does not yet have association support baked in. Based on what I have seen so far, that should be doable to add. See #345 for some additional background.
The primary design criteria here was to provide JSON API support without making any changes to existing functionality so as not to risk breaking anything already in place.