-
-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link URL getting encoded in react-markdown v9 #797
Comments
It is not. This is how HTML works. |
This comment has been minimized.
This comment has been minimized.
Hey @wooorm , This is causing issues due to invalid URL. Here's a screenshot for the comparison on your own site, please have a look. Can you please help me with a correct URL, with parameters. |
Never mind, I'll recreate another example. But this is breaking! |
It is not: there might be something else broken, likely on your end, of course. Feel free to try and reproduce the actual problem |
Ok, finally, I'm able to reproduce! Here you can see, in the markdown I've added a normal url from official sonarqube project You can see what's going on in network tab, the & gets converted to & and in-turn becomes an invalid query parameter. I'm willing to contribute a fix, but I have no idea where it's getting encoded from like this. I appreciate the effort you guys put to create the library, please help me narrow it down. |
Paste code so I can try it out |
Ohh, managed to reproduce! |
This comment has been minimized.
This comment has been minimized.
Sorry, I was out for a while, Here's a snippet you can try -
|
Released in 9.0.1! |
Awesome, thank you so much @wooorm 🙌 |
Initial checklist
Affected packages and versions
9.0.0
Link to runnable example
No response
Steps to reproduce
Go to: https://remarkjs.github.io/react-markdown/
Open Network panel in DevTools
Paste this in readme
Observed URL: https://github.com/remarkjs/react-markdown/workflows/main/badge.svg?v=123&branch=feat/router
Notice:
&
, this is causing issuesExpected behavior
URL should not be double encoded
Actual behavior
URL is being encoded in a weird way.
Runtime
No response
Package manager
No response
OS
No response
Build and bundle tools
No response
The text was updated successfully, but these errors were encountered: