fix(PrivateThirdPartyEndpoint): Swap order of load() params

relaycorp · Mar 10, 2021 · 9455af4 · 9455af4
1 parent 785a387
commit 9455af4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/src/main/java/tech/relaycorp/relaydroid/endpoint/ThirdPartyEndpoint.kt b/lib/src/main/java/tech/relaycorp/relaydroid/endpoint/ThirdPartyEndpoint.kt
@@ -25,7 +25,7 @@ public sealed class ThirdPartyEndpoint(
             thirdPartyPrivateAddress: String
         ): ThirdPartyEndpoint? =
             PublicThirdPartyEndpoint.load(thirdPartyPrivateAddress)
-                ?: PrivateThirdPartyEndpoint.load(firstPartyAddress, thirdPartyPrivateAddress)
+                ?: PrivateThirdPartyEndpoint.load(thirdPartyPrivateAddress, firstPartyAddress)
     }
 }
 
@@ -49,8 +49,8 @@ public class PrivateThirdPartyEndpoint internal constructor(
          */
         @Throws(PersistenceException::class)
         public suspend fun load(
-            firstPartyAddress: String,
-            thirdPartyAddress: String
+            thirdPartyAddress: String,
+            firstPartyAddress: String
         ): PrivateThirdPartyEndpoint? {
             val key = "${firstPartyAddress}_$thirdPartyAddress"
             return Storage.thirdPartyAuthorization.get(key)?.let { auth ->

diff --git a/lib/src/test/java/tech/relaycorp/relaydroid/endpoint/PrivateThirdPartyEndpointTest.kt b/lib/src/test/java/tech/relaycorp/relaydroid/endpoint/PrivateThirdPartyEndpointTest.kt
@@ -45,7 +45,7 @@ internal class PrivateThirdPartyEndpointTest {
         val firstAddress = UUID.randomUUID().toString()
         val thirdAddress = UUID.randomUUID().toString()
 
-        with(PrivateThirdPartyEndpoint.load(firstAddress, thirdAddress)!!) {
+        with(PrivateThirdPartyEndpoint.load(thirdAddress, firstAddress)!!) {
             assertEquals(firstAddress, firstPartyEndpointAddress)
             assertEquals(PDACertPath.PRIVATE_ENDPOINT.subjectPrivateAddress, address)
             assertEquals(PDACertPath.PRIVATE_ENDPOINT, pda)