-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add peer screen #23
Conversation
sdsantos
commented
Mar 31, 2021
- Android does not let me pick the .der file with any mimetype, so it let's the user pick any file.
- There's only a generic error message. Are there specific cases like an invalid certificate that we want to point out to the user?
- It's not validating the public address against the certificate (is that a possibility and, if so, should the SDK or the app validate it?)
- It does not currently support opening the app by clicking a certificate file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there specific cases like an invalid certificate that we want to point out to the user?
I think it'd be good to distinguish malformed vs invalid, especially because we couldn't limit the file picker to DER files.
It's not validating the public address against the certificate (is that a possibility and, if so, should the SDK or the app validate it?)
The SDK should do that in the future.
It does not currently support opening the app by clicking a certificate file
Since we can't limit this to DER files, I think we can defer that requirement. The alternative would be to allow users to open any file with the Ping app, which would be annoying for them to get that option whenever they want to open a file.
I've found a bug: I can't create the endpoint below. Here's its certificate.
I ran into this issue after creating and then deleting the ping.awala.services
endpoint.
Logcat doesn't have anything relevant.
UPDATE: It just doesn't like the -
, which means there are two issues here:
- Domain names containing hyphens should be allowed.
- The user should be alerted to any validation issues. And the save button should be visibly disabled.
app/src/main/java/tech/relaycorp/ping/ui/peers/AddPublicPeerViewModel.kt
Show resolved
Hide resolved
29bd05f
to
870fe93
Compare
CI is failing. Will approve when it passes. |
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |