fix: Improve ReceiveMessagesTest with log asserts

[sdsantos]

Fixes #49

@gnarea Notice the failing test. Feels weird that deleting the ThirdPartyEndpoint is not enough, since it triggers another error. Are we forgetting to delete something inside the delete() method?

[gnarea]

As you noticed, this is failing with the error: MissingKeyException: There is no session key for 03d6f89f597e881f275831faaa7abb92553f18fc563e53494372db18461533178.

That's because this test currently simulates a situation where the 1st party endpoint exists when we start collecting parcels, but no longer exists by the time we get the parcel. However, I think what you meant to simulate is the scenario where the 1st party endpoint didn't even exist when parcel collection started -- that is, parcel.recipientAddress != channel.firstPartyEndpoint.privateAddress is what you want to replicate.

I think the former is worth testing to make sure it's handled (I don't think I considered this scenario but it's great we came across it as it could certainly happen in real life!)

I'm not sure we can test the latter, but I could be wrong: If the 1st party endpoint didn't exist when parcel collection started (because it never existed or it was deleted), then that should/will throw an InvalidMessageException in:

awala-endpoint-android/lib/src/main/java/tech/relaycorp/awaladroid/messaging/ReceiveMessages.kt

Lines 84 to 92 in bad9585

	val parcel = try {
	parcelCollection.deserializeAndValidateParcel()
	} catch (exp: RAMFException) {
	parcelCollection.disregard("Malformed incoming parcel", exp)
	return@mapNotNull null
	} catch (exp: InvalidMessageException) {
	parcelCollection.disregard("Invalid incoming parcel", exp)
	return@mapNotNull null
	}

... because the sender's PDA wouldn't have been issued by any id certificate of our 1st party endpoints.

Thoughts?

[gnarea]

By "I think the former is worth testing to make sure it's handled" I mean add a catch for MissingKeyException

[github-actions]

🎉 This PR is included in version 1.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀