Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename recursion level Enum and values #127

Open
Arithmomaniac opened this issue Sep 16, 2018 · 1 comment
Open

Rename recursion level Enum and values #127

Arithmomaniac opened this issue Sep 16, 2018 · 1 comment
Labels
breaking change

Comments

@Arithmomaniac
Copy link
Collaborator

@brycekbargar proposed the following instead of the current names/values for ObjectFieldsDepthLevel:

ObjectFieldsBehavior.NoRecursion
ObjectFieldsBehavior.ShallowRecursion
ObjectFieldsBehavior.FullRecursion

I like it.
After Fest, we can add these, and flag the ObjectFieldsDepthLevel as [Obsolete] (they would still work, as we could cast to ObjectFieldsBehavior type.). Eventually, we would be able to remove them.
@KalinaTSD
Copy link
Collaborator

This is something minor. It will be implemented by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arithmomaniac @KalinaTSD