Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A little bug in TimeoutMsgFromProto() #129

Open
meling opened this issue Sep 23, 2024 Discussed in #128 · 0 comments · May be fixed by #130
Open

A little bug in TimeoutMsgFromProto() #129

meling opened this issue Sep 23, 2024 Discussed in #128 · 0 comments · May be fixed by #130
Assignees
@meling
Labels
bug Something isn't working

Comments

@meling
Copy link
Member

meling commented Sep 23, 2024

Discussed in #128

Originally posted by ikmOfSA September 22, 2024
In TimeoutMsgFromProto() of convert.go, about line 165. The "if m.GetViewSig() != nil" seems to be a typo. It should be "m.GetMsgSig()"
@meling meling added the bug Something isn't working label Sep 23, 2024
@meling meling self-assigned this Sep 23, 2024
@meling meling linked a pull request Sep 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meling meling

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TimeoutMsgFromProto reported in issue 129 relab/hotstuff
1 participant
@meling