Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Don't ForEach when Len is what you want #116

Open
meling opened this issue Mar 9, 2024 · 0 comments
Open

Chore: Don't ForEach when Len is what you want #116

meling opened this issue Mar 9, 2024 · 0 comments

Comments

@meling
Copy link
Member

meling commented Mar 9, 2024

In leaderrotation/reputation.go:59-62 we do this:

numVotes := 0
voters.ForEach(func(hotstuff.ID) {
	numVotes++
})

It should do this:

numVotes := voters.Len()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meling