Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getCardSize() #47

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Add getCardSize() #47

merged 5 commits into from
Apr 17, 2023

Conversation

MrBartusek
Copy link

Pull Request Template for Home Assistant / Lovelace Card Repository

Overview

Hey! As per dev docs

image

This PR defines getCardSize() function that helps Lovelace to set up cards automatically. It returns 6 since card is 300px in height:

image

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Documentation update
  • Refactoring
  • Other (please describe):

Checklist

Please ensure that you have completed the following tasks before submitting your pull request:

  • I have read the contributing guidelines for this project.
  • I have tested my changes against the dev branch (or another appropriate branch) and verified that they are working as expected.
  • I have updated the documentation (if applicable) to reflect my changes.
  • My changes adhere to the repository's code style guidelines.
  • My changes do not introduce any breaking changes or unexpected behaviors.

Related Issues / Pull Requests

None

Additional Details

Nope

@avataar
Copy link
Collaborator

avataar commented Apr 17, 2023

@ThomDietrich, I believe this would be a good opportunity to release the symbolic 1.0.0 version before we proceed with the big changes. What do you think?

@ThomDietrich ThomDietrich mentioned this pull request Apr 17, 2023
@MrBartusek
Copy link
Author

image
this check doesn't work on forks since like a year

@avataar
Copy link
Collaborator

avataar commented Apr 17, 2023

image
this check doesn't work on forks since like a year

We are aware. Any idea how to disable it for a PR from a fork (but still keep it for PRs from our project)?

@MrBartusek
Copy link
Author

We are aware. Any idea how to disable it for a PR from a fork (but still keep it for PRs from our project)?

I don't think you can do that, you can just disable it on all PRs. You don't need this check on prs since you will very rarely modify hacs manifest

@MrBartusek MrBartusek requested a review from ThomDietrich April 17, 2023 15:38
@ThomDietrich ThomDietrich merged commit 3e5eab2 into rejuvenate:main Apr 17, 2023
@ThomDietrich ThomDietrich added the release:minor (x.X.x) Bump the semantic version and release a build to HACS label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:minor (x.X.x) Bump the semantic version and release a build to HACS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants