About the future of 'home-assistant-sun-card' via this fork

[ThomDietrich]

Hey all,
looking forward to continue the development of home-assistant-sun-card in this repository.
AitorDB#164

Let's discuss first steps.

1. Add some context about this fork to the README file
2. Create PRs for the PRs currently open in the original repository
3. Merge all translation PRs from the original repository
4. Publish this repository to HACS

[selfish]

Hi @ThomDietrich,

I appreciate your proposal and find it to be well-thought-out. Regarding point (2), I recommend creating issues and inviting the original contributors to resubmit their PRs against our fork. This approach will not only increase awareness of our fork as the lead for the old repo but also foster collaboration among contributors.

Additionally, I suggest prioritizing the publication of this repository to HACS, given the evident demand. To comply with naming conventions for cards, we may need to adjust the repository name to lovelace-sun-card. This change will ensure consistency and improve discoverability within the HACS ecosystem.

If you agree with these suggestions, let's proceed with renaming the repo and implementing the proposed changes.

[avataar]

Inviting the original contributors sounds like a great idea. Let's go with the rename and push it to HACS!

[selfish]

Awesome, on it.
Thank you!

[selfish]

Oh, it looks like we have rather limited access to the repo settings.
@ThomDietrich could you please help us rename the repo to lovelace-sun-card so we can go ahead and re-submit it to HACS?
Thanks!

[ThomDietrich]

Hey both,
bare with me. Why do we need lovelace in the name? The name is discouraged and the majority half of popular repos follows the sun_card schema: https://github.com/topics/lovelace-card

Could you point me to the HACS recommendations you are talking about?

[ThomDietrich]

Inviting the original contributors to resubmit their PRs against our fork.

I agree with this for feature PRs as well as for users which raised interesting issues in the past. I suggest to wait till after the repo was published to HACS. This way we can not only trigger users for their contribution&feedback, but also help them transition to the news project on HACS.

I would make an exception regarding the translations. They are rather small and were one-shot contributions. I suggest to simply cross-merge these PRs directly into a branch and open a PR for public discussion. This will not break the git authors and we can ask all original contributors for feedback. Wdyt?

[selfish]

Could you point me to the HACS recommendations you are talking about?

After looking up where I read that, I realized I was initially mistaken about HACS' naming requirements. While it's true that they recommend the lovelace-card-name convention for cards, it's not a strict rule, and they do allow for other naming patterns, especially in the case of legacy repos.

However, I believe that adopting the lovelace-card-name convention would be a beneficial move for our project. This naming pattern is recognizable and trusted within the Home Assistant community. By following this convention, our repo's name would be easily identifiable and could potentially lead to greater adoption and trust among users.

I think it's worth considering, given the potential benefits. I'd love to hear your thoughts on this and whether you'd be open to making the change.

Thanks for considering, and I'm looking forward to hearing your opinions!

[selfish]

I suggest to wait till after the repo was published to HACS.

I agree

I would make an exception regarding the translations.

I agree

[selfish]

Hmm, another thought I have: Seeing how this issue is developing into a multi-topic discussion, and it is becoming quite long, why don't we enable Discussions on the repo? Since we're going to be using GitHub to collaborate here, it may be beneficial for the three of us to run discussions over there.

[ThomDietrich]

This initial ticket evolved into a discussion, but all future tickets will expectedly stay short. Let's not rush things.

Thanks for considering...

No further pushback from my side :)

[ThomDietrich]

Next steps:

...[deleted]

See next post.

[selfish]

The plan looks good.

Thank you for renaming the repository. I really appreciate your adaptability.

[ThomDietrich]

Hey guys,
I think it would be important to publish a new release and register with HACS default repo asap.

These are the steps:

• Resolve conflicts and merge Config Updates #4 @selfish (let's get this finished, even though it's not strictly needed for the release)
• Agree on project name, see moon support #11 @selfish @avataar
• Build a testing release, test locally
• Publish Github Release (anticipating the version 1.0 to be released soon)
• Publish to HACS: https://hacs.xyz/docs/publish/include/
• The project is ready for broad use and continued development

[tjorim]

Lovelace was more of a project name, it's not the 'official' name (anymore).
The HA repo is renamed to frontend and all other documentation talks about Dashboards.

Edit: proposed some names here.

[ThomDietrich]

@edwardtfn regarding your question in #4, the list above shows what needs to happen next.

[kquinsland]

I just wanted to say THANK YOU for picking this up. The repo / new releases are already in HACS and it was maybe 20 seconds for me to re-add it and adjust my dashboards. Couldn't have been simpler and for that I am grateful. Not all project re-incarnations go so smoothly!

[edwardtfn]

I've added comments on #21 about minor differences when compared to the original card (which migrating users will do) but I think it's time to wrap up and request inclusion to HACS default directory.
Have someone already started that? I couldn't find any PR for this on HACS.

@ThomDietrich, on HACS instructions it says this should be requested by the repo owner, but I believe we can manage that, so if you need help on this I can request that in your behalf.

[ThomDietrich]

@edwardtfn Didn't start before the rename to "horizon-card" was settled. Now it is time (!) and please go ahead, we are all equals here!

@kquinsland thanks for the positive words! We all know how sad it is to see beautiful projects disappear due to individual life changes, and we wish to give the community around the sun-card component a new home

[ThomDietrich]

@edwardtfn of course let us know if you need any further input to publish the project to HACS :)

[edwardtfn]

Done!

hacs/default#1808

[gpongelli]

waiting for this fork being available in HACS 😉

[ThomDietrich]

Fyi I was pleasantly surprised to see that we have been mentioned here: https://smarthomescene.com/blog/top-10-home-assistant-weather-cards/

[edwardtfn]

Th PR to add into HACS default repository was rejected. 😩
hacs/default#1808

[ThomDietrich]

This is devastating. Sorry @edwardtfn, three months for nothing.

New PR: hacs/default#1958 (please check for any errors 🙃)

[khenderick]

I noticed that you had reverted an end-of-file newline change, but it looks like there's still an end-of-file newline change on the PR. Maybe it's best to revert that so it doesn't get closed if no such newline is allowed 🤔 .

[ThomDietrich]

Thanks @khenderick! The newline was introduced by the GitHub online editor (which I used for this simple addition). Wonder how many others are burdened with this. It's bad practice to not have newline at the end of this file but anyhooow, I've fixed it. Thanks for your review!

[avataar]

It's really disappointing to see the HACS addition declined, especially having to wait that long for something that shouldn't take more than a day. Hopefully we'll have more luck now.

[edwardtfn]

It was merged!!!
hacs/default#1958

[ThomDietrich]

Finally!