Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dub broken if compiled with absolute path DC #506

Merged
merged 1 commit into from
Feb 11, 2015
Merged

Fix: dub broken if compiled with absolute path DC #506

merged 1 commit into from
Feb 11, 2015

Conversation

mihails-strasuns
Copy link

More broken things found by my test suite ;)

Code that was supposed to find working compiler always tried to
build absolute path from compiler name - even it was absolute
path already.

@MartinNowak
Copy link
Member

tabs plz, see EditorConfig

@MartinNowak
Copy link
Member

Otherwise LGTM

@mihails-strasuns
Copy link
Author

Fixed spaces

Code that was supposed to find working compiler always tried to
build absolute path from compiler name - even it was absolute
path already.
MartinNowak added a commit that referenced this pull request Feb 11, 2015
Fix: dub broken if compiled with absolute path DC
@MartinNowak MartinNowak merged commit a722966 into dlang:master Feb 11, 2015
MartinNowak added a commit that referenced this pull request Feb 11, 2015
- only use absolute initialCompilerBinary paths
- don't try to find absolute initialCompilerBinary in
  PATH
@MartinNowak
Copy link
Member

I added a fixup 00c5478.

@mihails-strasuns
Copy link
Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants