Fixed singleFile build mode issues #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
machindertech
commented
Feb 9, 2015
machindertech
commented
- Fixed error with long command line when invoking the linker on Windows
- Fixed issue where singleFile build mode builds each file as a static library instead of as an object file
- Fixed object file naming on Windows
|
|
||
| static string pathToObjName(string path) | ||
| { | ||
| return std.path.stripDrive(std.path.buildNormalizedPath(getcwd(), path~objSuffix))[1..$].replace(std.path.dirSeparator, "."); |
+ Fixed error with long command line when invoking the linker + Fixed object file naming
…ct files in singleFile build mode + Added object TargetType that is used during singleFile build mode
machindertech
force-pushed
the
singleFileFixes
branch
from
ef035d5 to
0dc606e
Compare
|
Thank you for the feedback! We've made changes to how object files are handled in the build settings based on the comments by MartinNowak. |
MartinNowak
added a commit
that referenced
this pull request
Feb 12, 2015
Fixed singleFile build mode issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.