Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable library targets for LDC compiler. #296

Merged
merged 1 commit into from
Apr 3, 2014
Merged

Enable library targets for LDC compiler. #296

merged 1 commit into from
Apr 3, 2014

Conversation

dmakarov
Copy link
Contributor

@dmakarov dmakarov commented Apr 3, 2014

Library targets for LDC compiler. Without these targets DUB is useless with LDC.

@s-ludwig
Copy link
Member

s-ludwig commented Apr 3, 2014

Thanks! Seems like nobody tried LDC with 0.9.21 so far... (btw. a possible workaround is to use dub --combined)

Just one question regarding the patch: did you test generating a shared library? From what I've read, -relocation-model=pic should also be necessary.

@dmakarov
Copy link
Contributor Author

dmakarov commented Apr 3, 2014

I believe ldc2 generates pic code when -shared is used (no need to specify relocation model explicitly), but no I haven't test shared lib target. Also ldc2 seems to have issues with the linker command when -shared is used. I'll look more into it, but for now perhaps it's good to enable these targets instead of asserting... The static lib generation definitely works.

Thanks!

@s-ludwig
Copy link
Member

s-ludwig commented Apr 3, 2014

Yeah, shared libraries also still have other issues (e.g. when static dependencies are also involved), so it's low priority right now anyway. I'll merge it like this for now.

s-ludwig added a commit that referenced this pull request Apr 3, 2014
Enable library targets for LDC compiler.
@s-ludwig s-ludwig merged commit da74740 into dlang:master Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants