Skip to content
This repository has been archived by the owner on Jul 18, 2023. It is now read-only.

Add a way to configure Port Number #217

Closed
DrPleaseRespect opened this issue Aug 11, 2022 · 2 comments · Fixed by #221
Closed

Add a way to configure Port Number #217

DrPleaseRespect opened this issue Aug 11, 2022 · 2 comments · Fixed by #221

Comments

@DrPleaseRespect
Copy link

Describe the bug
Revanced Builder crashes due to hardcoded 8080 Port Value

While it's possible to temporarily disable the server that uses the 8080 port, I think it's better to have an option to change the port number instead.

To Reproduce
Steps to reproduce the behavior:

  1. Have a server that's already running on Port Number 8080 (i.e qBittorrent Web User Interface)
  2. Try to start ReVanced-Builder

Screenshots

Open Screenshot

revanced-builder Version: v3.1.7

Desktop (please complete the following information):

  • OS: Windows
  • Version: 11 22H2 (OS Build 22621.232)
@shrihankp
Copy link
Collaborator

I think, instead of asking the user to do it, I could make it intuitively choose which port it can bind to.

@DrPleaseRespect
Copy link
Author

As long as it's possible to resolve conflicts that's fine with me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants