Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine if person is a mentor/mentee based on whether they provide information on these topics #51

Open
igal opened this issue Nov 5, 2011 · 1 comment

Comments

@igal
Copy link
Collaborator

igal commented Nov 5, 2011

I'm not keen on the person form asking me "Would you like to be a mentor?" and "mentee?" when it could just check to see if I've put anything into the associated textareas to determine this on its own.

This should be a fairly simple change:

  • Remove the checkboxes from the person#_form.
  • Add Person#mentor? and Person#mentee? and use those instead of the current checks in the person#show form.
  • Rework the Person::mentors and ::mentees scopes to return records whose "mentor_topics" and "mentee_topics" are present.

Thoughts?

@reidab
Copy link
Owner

reidab commented Nov 5, 2011

I'd prefer to see the mentorship checkboxes show/hide the text fields, in order to save form space for people who aren't interested in mentoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants