Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up R CMD CHECK workflow #405

Closed
2 tasks done
nickreich opened this issue Jan 12, 2024 · 3 comments · Fixed by #409
Closed
2 tasks done

clean up R CMD CHECK workflow #405

nickreich opened this issue Jan 12, 2024 · 3 comments · Fixed by #409
Assignees

Comments

@nickreich
Copy link
Member

nickreich commented Jan 12, 2024

@bsweger bsweger self-assigned this Jan 12, 2024
@bsweger
Copy link
Collaborator

bsweger commented Jan 12, 2024

@nickreich there's a render vignette step in the test action: https://github.com/reichlab/covidHubUtils/blob/master/.github/workflows/pr_unittest.yaml#L86

It uses the rmarkdown::render("vignettes/covidHubUtils-overview.Rmd") incantation, which looks like it executes the .Rmd code.

This may explain the --no-vignettes we see in the R CMD CHECK workflow.

Will this suffice for the second checkbox in the short term?

In the longer term, I'm going to create an issue to bring this repo's R CMD CHECK workflow in line with the corresponding workflows over in the hubverse, which make use of tools like r-lib/actions/check-r-package@v2 (for example)

Edit to add: I'm proposing the short term here so I can fast-track the local dev setup and work on the actual bug I'm assigned to 😅

@nickreich
Copy link
Member Author

I created the other issue just so we didn't lose it, and yes, I think for the short-term this should work. Let's get back to the assigned bug!

@bsweger
Copy link
Collaborator

bsweger commented Jan 26, 2024

Closing, as this was resolved in #409 (I used the wrong wording to auto link the ticket)

@bsweger bsweger closed this as completed Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants