The server starts crashing shortly after starting with the new versions of ReGameDLL!

[stambeto2006]

The server starts crashing shortly after starting!

With ReGameDLL version: 5.22.0.593 there is no problem with the server crashing, but if you install a new version and up, the server starts crashing constantly.

Hopefully this crash issue will be resolved so we can use the new and fixed bugs. Because from 5.22.0.593 up, the new ReAPI changes cannot be used either.
hlds_3.14.0.830-dev-c9f9bbf_crash_20240516_221217_1.zip

[dbogdan95]

Same problem here, same crash. It happen several times.

[Vaqtincha]

Last 5.26.0.668 (and dev builds) works perfectly.

[stambeto2006]

Last 5.26.0.668 (and dev builds) works perfectly.

@Vaqtincha It might work for certain mods this version but for other mods it crashes the server so I have attached the crash file. I have also tried with this version that you said and other versions that are not uploaded official as well as latest versions.

If it crashes the server then there is some problem with ReGameDLL, as I have taken the time to see from which version to which version this problem starts.

Hope the problem is found, I'm not the only one crashing with ReGameDLL.

[dbogdan95]

Last 5.26.0.668 (and dev builds) works perfectly.

I'm using this version and it is crashing. Absolutely the same crash report as @stambeto2006

Also I'm on CS 1.6.

[NiceFeatures]

Same

[s1lentq]

@stambeto2006
I looked at your crash dump.
The exceptions occurred at the endpoint of the ApplyMultiDamage hook, but it's not entirely clear how this happened.
Could you zip the server directory as it is and send it to my email?
I can't reproduce this crash.

[stambeto2006]

@s1lentq I am attaching new crash files from the newest and latest version of ReGameDLL.

This crash happens only and only no matter what version I put on CSDM.

hlds_3.14.0.830-dev-c9f9bbf_crash_20240529_152653_1.zip
hlds_3.14.0.830-dev-c9f9bbf_crash_20240529_152724_1.zip

[s1lentq]

@s1lentq I am attaching new crash files from the newest and latest version of ReGameDLL.

This crash happens only and only no matter what version I put on CSDM.

hlds_3.14.0.830-dev-c9f9bbf_crash_20240529_152653_1.zip hlds_3.14.0.830-dev-c9f9bbf_crash_20240529_152724_1.zip

It won't help me to find a way to reproduce this crash

[stambeto2006]

@s1lentq Maybe it will be in 1 or 2 weeks, I don't have the time to send it right now because it's on my other machine. Share your email so that if it happens to be sooner I can send it to you.

[dystopm]

@stambeto2006 @dbogdan95 check last commit, a check has been added after ApplyMultiDamage's TakeDamage call which may be a factor that is provoking those crashes. On any circumstances you may need to provide source codes of your mods because it's not regular to delete an entity before it received damage.

Download and try the latest dumped version.

[s1lentq]

it's not regular to delete an entity before it received damage.

Deleting an entity inside TakeDamage is another a potential crash case, but not for this issue

There, in fact, the issue with the causing another damage inside TakeDamage which leads to the current sets multidamage cleared with ClearMultiDamage calling from somewhere, therefore gMultiDamage.pEntity will become null after call gMultiDamage.pEntity->TakeDamage

I do not know how to reproduce this from the 3rd-party plugins, maybe it's instant damage with a laser beam, FireBullets3, RadiusDamage or something like that

Share your email

E-mail

[email protected]

[dbogdan95]

@stambeto2006 @dbogdan95 check last commit, a check has been added after ApplyMultiDamage's TakeDamage call which may be a factor that is provoking those crashes. On any circumstances you may need to provide source codes of your mods because it's not regular to delete an entity before it received damage.

Download and try the latest dumped version.

Fortunately, this fix seems to be working for me. However, there are still some additional crashes occurring.

I received a different crash dump this time.

hlds_crash_20240604_082045.mdmp.zip

[s1lentq]

@stambeto2006 @dbogdan95 check last commit, a check has been added after ApplyMultiDamage's TakeDamage call which may be a factor that is provoking those crashes. On any circumstances you may need to provide source codes of your mods because it's not regular to delete an entity before it received damage.
Download and try the latest dumped version.

Fortunately, this fix seems to be working for me. However, there are still some additional crashes occurring.

I received a different crash dump this time.

hlds_crash_20240604_082045.mdmp.zip

Which build of regamedll were you using at the time of the crash? It doesn't look like the latest or recent builds
Give the output of game version from console

[dbogdan95]

@stambeto2006 @dbogdan95 check last commit, a check has been added after ApplyMultiDamage's TakeDamage call which may be a factor that is provoking those crashes. On any circumstances you may need to provide source codes of your mods because it's not regular to delete an entity before it received damage.
Download and try the latest dumped version.

Fortunately, this fix seems to be working for me. However, there are still some additional crashes occurring.
I received a different crash dump this time.
hlds_crash_20240604_082045.mdmp.zip

Which build of regamedll were you using at the time of the crash? It doesn't look like the latest or recent builds Give the output of game version from console

Its the last commit:

game version
ReGameDLL version: 5.27.0.715-dev
Build date: 18:58:21 Jun 02 2024
Build from: ad1c58c

[dbogdan95]

@s1lentq

I have tried to recompile it locally on windows, and now seems that I see the errors better.

I'm uploading the dump on Drive because its bigger then Github accept:
https://drive.google.com/file/d/18U0F4bSvC9f0zWy6kjsIo72ft0_Dd5pB/view?usp=drive_link

EDIT: Is possible to be same the issue as #957

[dbogdan95]

Me again :)))

Another crash here:

https://drive.google.com/file/d/11u0uyDdXmkB1dUxGVLb9kVuS5V5Jfogw/view?usp=sharing

I think everywhere that GetWeatherPtr is used should validate for a null pointer.

[s1lentq]

I think everywhere that GetWeatherPtr is used should validate for a null pointer.

No, it's a dangling pointer and definitely not a null pointer.

All these dumps don't help figure out the main cause of why is m_pActiveItem pointer still storing dead entity
As I said above, I need server image in its current form, it will help a lot if I can reproduce this case

[snaike00]

Скиньте ему уже архив сервера, ведь это в ваших же интересах получить фикс.