Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noarch python migrator #3093

Open
wants to merge 54 commits into
base: main
Choose a base branch
from
Open

feat: add noarch python migrator #3093

wants to merge 54 commits into from

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Nov 5, 2024

Description:

This PR adds a noarch: python migrator per CFEP-25.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.21805% with 34 lines in your changes missing coverage. Please review.

Project coverage is 77.74%. Comparing base (a9bd044) to head (fe2258c).

Files with missing lines Patch % Lines
conda_forge_tick/migrators/noarch_python_min.py 85.04% 32 Missing ⚠️
conda_forge_tick/make_migrators.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3093      +/-   ##
==========================================
+ Coverage   77.56%   77.74%   +0.17%     
==========================================
  Files         124      126       +2     
  Lines       13374    13640     +266     
==========================================
+ Hits        10374    10604     +230     
- Misses       3000     3036      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@beckermr beckermr marked this pull request as ready for review November 5, 2024 19:52
- python 3.6.*
- numpy
run:
- python >={{ python_min }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What precisely do you not understand?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants