Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piggyback migrator to drop {{ pin_compatible("numpy") }} #2469

Closed
Tracked by #1997
jakirkham opened this issue Apr 20, 2024 · 4 comments · Fixed by #2470
Closed
Tracked by #1997

Piggyback migrator to drop {{ pin_compatible("numpy") }} #2469

jakirkham opened this issue Apr 20, 2024 · 4 comments · Fixed by #2470

Comments

@jakirkham
Copy link
Contributor

As numpy already contains a run_exports, which has been present since numpy version 1.22.3 number 1 ( conda-forge/numpy-feedstock#262 ), and conda-forge is using numpy version 1.22 or newer, we can just rely on run_exports from numpy and drop pin_compatible from recipes

This is also important to prepare for building with numpy version 2.0, which builds packages with numpy version 1.x and 2.x support. As such pin_compatible would be unnecessarily strict by restricting packages built with it to numpy version 2.x when 1.x could have also been supported

As a result (based on discussion at the core meeting), we decided to add a piggyback migrator that would remove {{ pin_compatible("numpy") }}. This would help prepare for the NumPy 2 migrator. It also could couple with that migrator to upgrade to NumPy 2 and clean this pinning out at the same time

@jakirkham
Copy link
Contributor Author

cc @h-vetinari @isuruf @rgommers (please feel free to add or correct anything here)

@jakirkham
Copy link
Contributor Author

cc @beckermr (for awareness)

@beckermr
Copy link
Contributor

We need doc changes and possibly adjustments to the linter as well. Not sure if those were covered.

@jakirkham
Copy link
Contributor Author

jakirkham commented Apr 20, 2024

Please see issue: conda-forge/conda-forge.github.io#2156

Feel free to add anything else there

Edit: Didn't see a linter check for this, but please let me know if I missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants