-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piggyback migrator to drop {{ pin_compatible("numpy") }}
#2469
Comments
cc @h-vetinari @isuruf @rgommers (please feel free to add or correct anything here) |
cc @beckermr (for awareness) |
We need doc changes and possibly adjustments to the linter as well. Not sure if those were covered. |
Please see issue: conda-forge/conda-forge.github.io#2156 Feel free to add anything else there Edit: Didn't see a linter check for this, but please let me know if I missed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As
numpy
already contains arun_exports
, which has been present sincenumpy
version1.22.3
number1
( conda-forge/numpy-feedstock#262 ), and conda-forge is usingnumpy
version1.22
or newer, we can just rely onrun_exports
fromnumpy
and droppin_compatible
from recipesThis is also important to prepare for building with
numpy
version2.0
, which builds packages withnumpy
version1.x
and2.x
support. As suchpin_compatible
would be unnecessarily strict by restricting packages built with it tonumpy
version2.x
when1.x
could have also been supportedAs a result (based on discussion at the core meeting), we decided to add a piggyback migrator that would remove
{{ pin_compatible("numpy") }}
. This would help prepare for the NumPy 2 migrator. It also could couple with that migrator to upgrade to NumPy 2 and clean this pinning out at the same timeThe text was updated successfully, but these errors were encountered: