Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide batch denoms with 0 balance on all 3 columns from portfolio #1663

Closed
flagrede opened this issue Apr 17, 2023 · 3 comments
Closed

Hide batch denoms with 0 balance on all 3 columns from portfolio #1663

flagrede opened this issue Apr 17, 2023 · 3 comments
Labels
bug Something isn't working dev Engineering tasks

Comments

@flagrede
Copy link

flagrede commented Apr 17, 2023 •
edited by blushi
Loading

Description

Following slack discussion we need to investigate why sometimes credit batches are still showing up even without a balance on all 3 columns.

Note that a fix has already been made to hide these projects (see this PR) but some projects are still showing up.
@flagrede flagrede added the bug Something isn't working label Apr 17, 2023
@blushi
Copy link
Member

blushi commented Apr 17, 2023

that should be "Hide batch denoms" instead of "projects", right?

@blushi blushi changed the title Hide projects with 0 balance on all 3 columns Hide batch denoms with 0 balance on all 3 columns from portfolio Apr 17, 2023
@ryanchristo ryanchristo added the dev Engineering tasks label Jul 7, 2023
@ryanchristo
Copy link
Member

ryanchristo commented Jul 27, 2023 •
edited by blushi
Loading

Is this the same as what was resolved in regen-network/regen-web#1979? Can we close this issue or is this something different?

@blushi
Copy link
Member

blushi commented Jul 31, 2023

yeah I think this got fixed by regen-network/regen-web#1979

@blushi blushi closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working dev Engineering tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@flagrede @blushi @ryanchristo