Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users can view empty credit batches they previously held. #1949

Closed
3 tasks
S4mmyb opened this issue Jun 29, 2023 · 4 comments
Closed
3 tasks

Users can view empty credit batches they previously held. #1949

S4mmyb opened this issue Jun 29, 2023 · 4 comments
Labels
bug Something isn't working dev

Comments

@S4mmyb
Copy link
Member

S4mmyb commented Jun 29, 2023

Describe the bug
In my user profile I can view credit batches I previously held, but no longer hold.

To Reproduce

Expected behavior
Once I sell, or transfer a credit batch and no longer hold credits of that batch, they should disappear from the user profile.

Screenshots
image

Desktop (please complete the following information):

  • OS:
  • Browser:
  • Version:

Smartphone (please complete the following information):

  • Device:
  • OS:
  • Browser:
  • Version:

Additional context


For Admin Use

  • Not duplicate issue
  • Appropriate labels and zenhub epics applied
  • Appropriate contributors tagged
@S4mmyb S4mmyb added bug Something isn't working dev labels Jun 29, 2023
@blushi
Copy link
Member

blushi commented Jul 4, 2023

This issue comes from the ledger originally which doesn't prune credit batches with empty balance: regen-network/regen-ledger#1889 but such credit batches should be hidden already on the front-end, this was done as part of #1853
maybe some regression happened since then? cc/ @flagrede

@flagrede
Copy link
Collaborator

flagrede commented Jul 6, 2023

They should be hidden indeed, it might be a regression or another case that is not handled.

@ryanchristo
Copy link
Member

Is this the same as what was resolved in #1979? Can we close this issue or is this something different?

@blushi
Copy link
Member

blushi commented Jul 31, 2023

same as what was resolved in #1979

@blushi blushi closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev
Projects
None yet
Development

No branches or pull requests

4 participants