Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Buf Generate #29

Closed
haveanicedavid opened this issue Jan 26, 2022 · 3 comments
Closed

Set up Buf Generate #29

haveanicedavid opened this issue Jan 26, 2022 · 3 comments

Comments

@haveanicedavid
Copy link

haveanicedavid commented Jan 26, 2022

In regen-js, set up the buf generate with ts-proto + buf schema registry https://buf.build/regen/regen-ledger/ (we should also make sure we add all current proto files there, see https://github.com/regen-network/regen-ledger/tree/master/proto/regen)

There's an existing buf plugin for ts-proto stephenh/ts-proto#573 but since we're actually using a fork of ts-proto https://github.com/regen-network/ts-proto https://www.npmjs.com/package/@regen-network/ts-proto, we need to create our own plugin

Useful resources:

@haveanicedavid
Copy link
Author

@mhagel

@blushi
Copy link
Member

blushi commented Jun 28, 2022

@haveanicedavid @flagrede @mhagel @victordelval
Something to tackle pretty soon. Indeed in the protocgen.sh script, we use buf protoc, which has been removed as part of https://github.com/bufbuild/buf/releases/tag/v1.0.0 (see changelog there) so for the code generation to work, you'll need to use a version of buf prior to v1.0.0 for now, until we set up buf generate with buf yaml files. Please ping @AmauryM or @aaronc if you need any support on that when I'm on maternity leave.

@S4mmyb
Copy link
Member

S4mmyb commented Jun 28, 2022

Thanks for flagging this @blushi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants