-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future plans #75
Comments
My thinking looks something like this: Pyroma 4 will:
Pyroma 5 will
Pyroma 6:
Pyroma 4 is currently in beta, a good aim for Pyroma 5 would be summer 2022, Pyroma 6 before end of 2022. Other ideas:
|
Thanks for the updates. It looks like with Pyroma 4, |
Ah, yes, that makes sense. I'll fix that for beta 2. Do you have an example package this happens on that I can double check on? |
It just happened for me here: pyg-team/pytorch_geometric#4368 (needed to revert back to "3.3"). I made the following change here: content_type = data.get("long_description_content_type", None)
if content_type is None:
content_type = data.get("description_content_type", None) This fixed the error for me. Not sure if this is the best solution though :) |
It is correct, but also not. :-D I released 4.0b2, it should fix this. |
:P Thanks a lot for the quick fix :) |
Yeah, this basically comes back to the same naming issues we've discussed previously, which will hopefully be more fully resolved in future versions.
Any chance this could get moved up, since its a fully drop-in replacement that should be doable in two-ish lines? Otherwise, you have to maintain your bespoke tooling for another whole major release, which is likely to be more work than just switching now. I'm happy to drop a PR doing so if you're okay with it. |
Well, the tooling isn't much work, but yes, if you make a PR then I'll add it to 4.x. |
Please see PR #81. |
Looks good, thanks! |
Ugh, I'm so behind on this... |
Pyroma needs to be updated with supporting modern build systems and tools for Python. This has been rapidly changing the last few years, but it's finally looking like it's stabilized and is maturing, especially with the release of Setuptools 61 last week, that supports PEP621.
This thread is for discussion of those plans.
The text was updated successfully, but these errors were encountered: