Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu component for the web version #384

Open
cguedes opened this issue Aug 18, 2023 · 5 comments
Open

Menu component for the web version #384

cguedes opened this issue Aug 18, 2023 · 5 comments
Assignees
Labels
app:web enhancement New feature or request

Comments

@cguedes
Copy link
Collaborator

cguedes commented Aug 18, 2023

This is part of #347

Add a menu for the web that contains the relevant actions we have in the Desktop menu.
Also, we need to capture keyboard events for these menu actions (ex: save).

@cguedes cguedes self-assigned this Aug 18, 2023
@cguedes cguedes added enhancement New feature or request app:web labels Aug 18, 2023
@hammer
Copy link
Contributor

hammer commented Aug 19, 2023

Why do we need a menu for the web version? Aren’t all these commands available through the command palette?

@danvk
Copy link
Collaborator

danvk commented Aug 23, 2023

Yes, commands would all be available via the command palette. A menu would aid discoverability and consistency across the two platforms. If we're not going to have a menu in the web version then we should probably de-emphasize it in the desktop version, too.

Notion and Google Docs both have menu bars, though Google's is much more prominent/important.

Menu in Notion:

image

Menu in Google Docs:

image

@hammer
Copy link
Contributor

hammer commented Aug 23, 2023

While we're talking about menus, I wanted to note that in Tauri 2.0 there are several big changes to menus, for example tauri-apps/tauri#6617 (already found by @danvk), tauri-apps/tauri#7535, tauri-apps/tauri#4338 (context menus, but related). No action now, but it may impact our implementation strategy if we know a big change is coming.

@hammer
Copy link
Contributor

hammer commented Aug 23, 2023

@danvk I can see both sides of this argument. For a desktop app, a menu is quite natural and it's weird not to have it. For a web app, it's becoming increasingly unnatural. For example, Type and Wordtune do not have a menu.

Both Slack and Notion use the top-of-screen menu for their desktop app but don't replicate the top-of-screen menu functionality on their web app. Note that Notion desktop has both a top-of-screen menu and the menu you've pointed out that's discoverable under the "•••" in the upper right. Notion web only has the "•••" menu.

Overall I think the notion of a web app with a top-of-screen menu is a bit outdated and not necessary. I don't hold this position strongly though so if y'all think it's in error please let me know!

If we don't have a top-of-screen menu, maybe we have a ☰ or ••• element someplace that brings this functionality into the web app someplace else?

@danvk
Copy link
Collaborator

danvk commented Aug 23, 2023

I'm fine with no menu on the web version. We should, however, make sure that there's some on-screen, discoverable way to complete critical actions in the app. For example Notion auto-saves (so Save / CmdS isn't critical) and has an on-screen "+" button to add new documents:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:web enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants