Untangle node hierarchy #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raoulvdberge
force-pushed
the
refactor/NO-ISSUE/untangle-node-hierarchy
branch
3 times, most recently
from
58cc9f6 to
4cf3962
Compare
This can be moved to the base block entity instead.
…rkNodeContainerBlockEntity This belongs in the base block entity instead.
Moved to base block entity instead. There is only one block that has no redstone mode, and that one has a flag set.
This ensures that we can reuse it across the other block entities and remove AbstractSchedulingNetworkNodeContainerBlockEntity. * Move work tick rate to BaseNetworkNodeContainerBlockEntity. * Move calculation of speed and work tick rate to UpgradeContainer.
Removes #postDoWork.
raoulvdberge
force-pushed
the
refactor/NO-ISSUE/untangle-node-hierarchy
branch
2 times, most recently
from
17fd7aa to
02f5f08
Compare
raoulvdberge
force-pushed
the
refactor/NO-ISSUE/untangle-node-hierarchy
branch
from
02f5f08 to
dad98e0
Compare
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.