lib: simplify several debug() calls

Avoid calling Array.prototype.join() in debug() calls. These are evaluated on every call, even if the debug() call is a no-op. This commit replaces the join() calls with the %j placeholder. PR-URL: nodejs#25241 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
refack · Jan 10, 2019 · d880ab5 · d880ab5
1 parent 4db40e6
commit d880ab5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -477,8 +477,8 @@ function onOrigin(origins) {
   const session = this[kOwner];
   if (session.destroyed)
     return;
-  debug(`Http2Session ${sessionName(session[kType])}: origin received: ` +
-        `${origins.join(', ')}`);
+  debug('Http2Session %s: origin received: %j',
+        sessionName(session[kType]), origins);
   session[kUpdateTimer]();
   if (!session.encrypted || session.destroyed)
     return undefined;

diff --git a/lib/internal/modules/esm/create_dynamic_module.js b/lib/internal/modules/esm/create_dynamic_module.js
@@ -6,9 +6,7 @@ const ArrayJoin = Function.call.bind(Array.prototype.join);
 const ArrayMap = Function.call.bind(Array.prototype.map);
 
 const createDynamicModule = (exports, url = '', evaluate) => {
-  debug(
-    `creating ESM facade for ${url} with exports: ${ArrayJoin(exports, ', ')}`
-  );
+  debug('creating ESM facade for %s with exports: %j', url, exports);
   const names = ArrayMap(exports, (name) => `${name}`);
 
   const source = `