Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using query on DELETE requests in pact_verifier #94

Open
MazeDeveloper opened this issue Jun 29, 2020 · 3 comments
Open

Using query on DELETE requests in pact_verifier #94

MazeDeveloper opened this issue Jun 29, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@MazeDeveloper
Copy link

I implement provider tests for an API using QueryStrings on DELETE http method. The requests library would support that and I locally test that it would work when adding the use of query from the pact.json in the service_DELETE function like for e.g. in the service_GET function in the Interaction class of verify.py.

Is there a reason it is not supported? As far as I know it is correct to use QueryStrings on DELETE http method.

@r1chardj0n3s
Copy link
Collaborator

This is an oversight, I can't think of a reason to disallow query parameters in a DELETE.

@r1chardj0n3s r1chardj0n3s added the bug Something isn't working label Jun 30, 2020
@MazeDeveloper
Copy link
Author

I fixed the issue locally in a feature branch but I am not able to push it. Can I get permissions or how is that working? I followed the contributing.md. Alternatively would you fix the bug and I create a fork till fixed if it takes multiple day, so my team can continue? I don't want to bother you.

@r1chardj0n3s
Copy link
Collaborator

The way you can contribute is by opening a Pull Request against the project. The info about this is here: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request

Let me know if you need any further assistance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants