Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError if pact installed #120

Open
jayvdb opened this issue Sep 8, 2022 · 0 comments · May be fixed by #121
Open

AttributeError if pact installed #120

jayvdb opened this issue Sep 8, 2022 · 0 comments · May be fixed by #121

Comments

@jayvdb
Copy link

jayvdb commented Sep 8, 2022

When https://github.com/getslash/pact is installed, pactman breaks with:

  File "/usr/lib/python3.10/site-packages/pactman/mock/matchers.py", line 308, in <module>
    LIKE_CLASSES = (Like, pact_python.Like)
AttributeError: module 'pact' has no attribute 'Like'

The code in question is looking for https://github.com/pact-foundation/pact-python , and only guards for ImportError, when it should also guard against other exceptions.

@jayvdb jayvdb linked a pull request Sep 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant