Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change lifetime of the AzureSigningKey service #7

Closed
reecerussell opened this issue Sep 4, 2023 · 0 comments
Closed

Change lifetime of the AzureSigningKey service #7

reecerussell opened this issue Sep 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@reecerussell
Copy link
Owner

The lifetime of the AzureSigningKey should be extended, to maybe singleton, as when a new instance is created in very quick succession, a client may hit the Azure rate limits. This is common on creating a new instance per request.

rusty-jwt/Rusty.Jwt.Azure/Extensions/JwtServiceBuilderExtensions.cs

Line 18 in 9132c38

builder.Services.AddTransient(_ =>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reecerussell