fix: prevent selecting not shown feature for MVT on reearth/core (#589)

reearth · Mar 30, 2023 · 41816de · 41816de
1 parent e138bd6
commit 41816de
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/core/engines/Cesium/Feature/Raster/hooks.ts b/src/core/engines/Cesium/Feature/Raster/hooks.ts
@@ -191,7 +191,12 @@ export const useMVT = ({
             : idFromGeometry(mvtFeature.loadGeometry(), tile);
           const feature = evalFeature(layer, makeFeatureFromPolygon(id, mvtFeature, tile));
           const info = new ImageryLayerFeatureInfo();
-          info.data = { layerId: layer?.id, featureId: id, feature };
+          info.data = {
+            layerId: layer?.id,
+            featureId: id,
+            feature,
+            appearanceType: VectorTileFeature.types[mvtFeature.type].toLowerCase(),
+          };
           return info;
         },
       });

diff --git a/src/core/engines/Cesium/hooks.ts b/src/core/engines/Cesium/hooks.ts
@@ -455,6 +455,11 @@ export default ({
           const l = await scene.imageryLayers.pickImageryLayerFeatures(pickRay, scene);
           if (l && !!l.length) {
             l.map(f => {
+              const appearanceType = f.data?.appearanceType;
+              if (appearanceType && f.data?.feature?.[appearanceType]?.show === false) {
+                return;
+              }
+
               const pos = f.position;
               if (pos) {
                 // NOTE: Instantiate temporal Cesium.Entity to display indicator.