-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid naming conflict with client
prop
#7024
Merged
Merged
Changes from 22 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
ddc5f41
fix: avoid naming conflict with `client` prop
esteban-url fd48a95
fix: disable lint error for prefer-const
esteban-url 76d7967
Merge branch 'main' into er-client-name-conflict
esteban-url 6223bd8
Merge branch 'main' into er-client-name-conflict
esteban-url fc57f82
Merge branch 'redwoodjs:main' into er-client-name-conflict
esteban-url b991c9a
Merge branch 'main' into er-client-name-conflict
esteban-url d2882de
Merge branch 'main' into er-client-name-conflict
esteban-url ef0dfda
Merge branch 'main' into er-client-name-conflict
esteban-url e400605
Merge branch 'main' into er-client-name-conflict
esteban-url 69d82c2
Merge branch 'main' into er-client-name-conflict
esteban-url 4a8bfb9
Merge branch 'main' into er-client-name-conflict
esteban-url d5076ea
Merge branch 'main' into er-client-name-conflict
esteban-url 15b2087
Merge branch 'main' into er-client-name-conflict
esteban-url 1b42989
Merge branch 'main' into er-client-name-conflict
esteban-url 7fdbdcb
Merge branch 'main' into er-client-name-conflict
esteban-url 2c04417
Merge branch 'main' into er-client-name-conflict
esteban-url 06fe88c
Merge branch 'main' into er-client-name-conflict
esteban-url 39feae7
Merge branch 'main' into er-client-name-conflict
esteban-url 8af713a
Merge branch 'main' into er-client-name-conflict
esteban-url ae2bca6
Merge branch 'main' into er-client-name-conflict
esteban-url 129da34
refactor: group variables under queryResult
esteban-url 0d2b9e6
fix: add type safety for handling errorCode
esteban-url 40350de
Merge branch 'main' into er-client-name-conflict
esteban-url 7a1aad5
Merge branch 'main' into er-client-name-conflict
esteban-url c49f512
Merge branch 'main' into er-client-name-conflict
esteban-url 1d89820
refactor: deconstruct props directly
esteban-url 9ed4084
Merge branch 'main' into er-client-name-conflict
esteban-url 3faae96
Merge branch 'main' into er-client-name-conflict
esteban-url ec3808c
Merge branch 'main' into er-client-name-conflict
esteban-url d1f57f6
Codemod for cell parameter adjustments
Josh-Walker-GM 9557318
Merge branch 'main' into er-client-name-conflict
Josh-Walker-GM c5a6f37
Merge branch 'main' into er-client-name-conflict
jtoar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure that adding an ad-hoc type is the best way to handle the
errorCode
. would love feedback on this fix 🤓There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a change to existing behavior, right? Where exactly is
errorCode
coming from? Why weren't we using it before?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This showed up when running the test suite on this test: https://github.com/redwoodjs/redwood/blob/main/packages/web/src/components/createCell.test.tsx#L260
Before my change the
queryRest
destructuring was overriding theerrorCode
prop:But because it's now a part of
queryResult
theerrorCode
is never set. So the test referenced above fails.Should we be destructuring and overwriting
error
anderrorCode
?