Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: FastifyError [Error]: The decorator 'urlData' has already been added! #9789

Closed
1 task
SquirrelJimmy opened this issue Jan 2, 2024 · 2 comments · Fixed by #9794
Closed
1 task
Assignees
Labels
bug/confirmed We have confirmed this is a bug topic/fastify Fastify topic/server Serverful

Comments

@SquirrelJimmy
Copy link

SquirrelJimmy commented Jan 2, 2024

What's not working?

when build project, use api-server start both-server(api&web) with cmd @redwoodjs/api-server --port 8910 catch error FastifyError [Error]: The decorator 'urlData' has already been added!
This error catch above v6.6.0

How do we reproduce the bug?

  1. yarn rw build
  2. node ./node_modules/@redwoodjs/api-server/dist/index.js --port 8910

@fastify/url-data plugin regist two times in withWebServer & withFunctions

What's your environment? (If it applies)

No response

Are you interested in working on this?

  • I'm interested in working on this
@SquirrelJimmy SquirrelJimmy added the bug/needs-info More information is needed for reproduction label Jan 2, 2024
@tbay06
Copy link

tbay06 commented Jan 2, 2024

I can confirm this issue is reproducible on a freshly installed 6.6.1 redwood app when using yarn rw exp setup-docker as well - it seems to be happening in any implementation that uses the rw-server package directly, with the changes introduced here #9714 likely the culprit. See also RedwoodJS deployment is not working and Fly.io deployment help

@Josh-Walker-GM Josh-Walker-GM added bug/confirmed We have confirmed this is a bug and removed bug/needs-info More information is needed for reproduction labels Jan 3, 2024
@Josh-Walker-GM
Copy link
Collaborator

Thanks for the issue @SquirrelJimmy and the confirmation @tbay06!

I'll take a look at this tomorrow (hopefully) and we can see about getting a fix merged and ready for release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/fastify Fastify topic/server Serverful
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants