Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?]: docker image does not install redwood #9321

Closed
1 task done
Jonathan-Dobson opened this issue Oct 20, 2023 · 2 comments
Closed
1 task done

[Bug?]: docker image does not install redwood #9321

Jonathan-Dobson opened this issue Oct 20, 2023 · 2 comments
Labels
bug/needs-info More information is needed for reproduction

Comments

@Jonathan-Dobson
Copy link

What's not working?

It appears the rw-server was not installed.

02-rw-db-1       | 2023-10-20 01:11:19.416 UTC [1] LOG:  database system is ready to accept connections
02-rw-api-1      | node:internal/modules/cjs/loader:1080
02-rw-api-1      |   throw err;
02-rw-api-1      |   ^
02-rw-api-1      |
02-rw-api-1      | Error: Cannot find module '/home/node/app/node_modules/.bin/rw-server'
02-rw-api-1      |     at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
02-rw-api-1      |     at Module._load (node:internal/modules/cjs/loader:922:27)
02-rw-api-1      |     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
02-rw-api-1      |     at node:internal/main/run_main_module:23:47 {
02-rw-api-1      |   code: 'MODULE_NOT_FOUND',
02-rw-api-1      |   requireStack: []
02-rw-api-1      | }
02-rw-api-1      |
02-rw-api-1      | Node.js v18.18.2
02-rw-console-1 exited with code 0
02-rw-api-1 exited with code 1
02-rw-web-1      | /bin/sh: 1: node_modules/.bin/rw-web-server: not found

How do we reproduce the bug?

  1. clone a project and cd into it.
  2. add the four docker files as described int redwood github docker section into the root directory of the project.
  3. Start up dev: docker compose -f ./docker-compose.prod.yml up or build it with docker build .

What's your environment? (If it applies)

Docker

Are you interested in working on this?

  • I'm interested in working on this
@Jonathan-Dobson Jonathan-Dobson added the bug/needs-info More information is needed for reproduction label Oct 20, 2023
@Josh-Walker-GM
Copy link
Collaborator

Hey @Jonathan-Dobson! These packages are currently added when you use the yarn rw exp setup-docker command - you can see this in the code here if you're interested. This command also does a few other tasks to ensure everything needed for our dockerfile setup is present in your project.

Currently we're working on updating our dependencies and how they're imported into your project - for exactly this reason of keeping the production container image small. Hopefully in the near future redwood projects will ship with these dependencies by default so that a default redwood projects works with the dockerfile without any additional dependencies being installed.

Has this been helpful?

@jtoar
Copy link
Contributor

jtoar commented Oct 26, 2023

Thanks for your interest in Docker @Jonathan-Dobson! I'm going to close this for now since this feature hasn't been released yet and I believe @Josh-Walker-GM pointed out the issue. It'll be released soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/needs-info More information is needed for reproduction
Projects
None yet
Development

No branches or pull requests

3 participants