-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top documentation result in Google 404s #4335
Comments
@markerikson Is this caused by the Docusaurus upgrade? This might affect other pages. |
Very likely related, yes. I upgraded DS and it suddenly started reporting a CI of broken links, which were the style guide and other pages linked in the header and footer. Part of it seemed to be changed handling of files named README. I thought I fixed them, but wouldn't be surprised if there's other problems. @slorber : any idea what would have caused these links to break with a DS upgrade? |
It looks like the Style Guide page may now be pointing to https://redux.js.org/style-guide/ , instead of That's... weird. Why would this have suddenly changed? |
I've replied on Discord. For reference, it's because of facebook/docusaurus#5830 which means You can revert to the previous behavior with |
Yeah, I think I'm inclined to agree as far as URL patterns go. Let me try updating that PR to do a redirect instead. |
Sorry for that As you are using Netlify you can add a This is what we do on our own website: https://github.com/facebook/docusaurus/blob/main/website/static/_redirects |
Thanks for the quick fix! |
What docs page needs to be fixed?
What is the problem?
The top Google result for
redux style guide
looks to be an old route that 404s: https://redux.js.org/style-guide/style-guideWhat should be changed to fix the problem?
A redirect should be implemented to take users from this broken link to the actual style guide section.
The text was updated successfully, but these errors were encountered: