-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
browser
field in package.json
#2345
Comments
Sorry, I thought I responded to this. Must have been in my head... But yeah, this would seem to be a problem. However, we're looking at bundling the es/cjs builds as well (#2358), so maybe it won't be an issue then? |
@timdorr I'm afraid it's still an issue w/ default configuration of webpack. If Link: https://webpack.js.org/configuration/resolve/#resolve-mainfields I think it makes sense to remove this field in #2358 (or I can submit another PR). |
I finally got rid of this. Thanks for the heads up! |
This is picked up in Webpack by default and will cause all sorts of headaches. Fixes reduxjs#2345
If next release will be published w/
browser
field inpackage.json
, then webpack will be using umd build on bundling instead ofmodule
/main
builds.Webpack issue: webpack/webpack#4674
The text was updated successfully, but these errors were encountered: