Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce main bundle with Rollup #2245

Closed
gaearon opened this issue Feb 16, 2017 · 5 comments
Closed

Produce main bundle with Rollup #2245

gaearon opened this issue Feb 16, 2017 · 5 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Feb 16, 2017

There are unfortunate Babel artifacts in the compiled UMD bundle.
For example:

return e&&e.__esModule?e:{"default":e}}t.__esModule=!0
// Oops, we access ["default"] in a hot path!
if(!(0,u["default"])(e))throw Error("Actions must be plain objects. Use custom middleware for async actions.")

We should use a better build process that doesn’t produce artifacts like this.

@timdorr
Copy link
Member

timdorr commented Feb 16, 2017

This is due to the oldIE support stuff, right? Shouldn't be happening in next branch. Scope hoisting (aka, rollup) won't fix this by itself.

@gaearon
Copy link
Contributor Author

gaearon commented Feb 16, 2017

I meant the Babel default indirection which goes away if we compile with Rollup.

@TrySound
Copy link
Contributor

TrySound commented Mar 7, 2017

@gaearon Do you want a PR?

@gaearon
Copy link
Contributor Author

gaearon commented Mar 7, 2017

Sure.

@TrySound
Copy link
Contributor

TrySound commented Mar 7, 2017

@gaearon Done

@timdorr timdorr closed this as completed Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants