Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put action after state with default value in reducer will cause jshint to complain #1410

Closed
anianj opened this issue Feb 16, 2016 · 1 comment

Comments

@anianj
Copy link

anianj commented Feb 16, 2016

JSHint will report:
Regular parameters should not come after default parameters. W138

@gaearon
Copy link
Contributor

gaearon commented Feb 16, 2016

Well, we don’t agree with this particular rule. You can either disable it, or not use optional parameters and write something like

function counter(state, action) {
  if (typeof state === 'undefined') {
    return 0
  }

  switch (action.type) {
    // ...
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants